Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bloated comments from translation files #74789

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Remove bloated comments from translation files #74789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lang/string_extractor/parsers/gun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ def parse_gun(json, origin):
if "modes" in json:
for mode in json["modes"]:
write_text(mode[1], origin,
comment="Firing mode of gun \"{}\"".format(name))
comment="Firing mode of gun")

if "skill" in json:
if json["skill"] != "archery":
write_text(json["skill"], origin, context="gun_type_type",
comment="Skill associated with gun \"{}\"".format(name))
comment="Skill associated with gun")

if "reload_noise" in json:
write_text(json["reload_noise"], origin,
Expand All @@ -45,5 +45,4 @@ def parse_gun(json, origin):
if "valid_mod_locations" in json:
for loc in json["valid_mod_locations"]:
write_text(loc[0], origin,
comment="Valid mod location of gun \"{}\""
.format(name))
comment="Valid mod location of gun")
6 changes: 3 additions & 3 deletions lang/string_extractor/parsers/gunmod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def parse_gunmod(json, origin):
if "mode_modifier" in json:
for mode in json["mode_modifier"]:
write_text(mode[1], origin,
comment="Firing mode of gun mod \"{}\"".format(name))
comment="Firing mode of gun mod")

if "variants" in json:
for variant in json["variants"]:
Expand All @@ -28,9 +28,9 @@ def parse_gunmod(json, origin):

if "location" in json:
write_text(json["location"], origin,
comment="Location of gun mod \"{}\"".format(name))
comment="Location of gun mod")

if "mod_targets" in json:
for target in json["mod_targets"]:
write_text(target, origin, context="gun_type_type",
comment="Target of gun mod \"{}\"".format(name))
comment="Target of gun mod")
Loading