Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit roofs to hunting blinds #74782

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Add explicit roofs to hunting blinds without relying on add_roofs magic.

Describe the solution

Define roof chunks for the blinds and nest those to the blinds.

Describe alternatives you've considered

Testing

Debug spawn 6 hunting blinds and hope both versions appear. Teleport there and examine the results.
Screenshot (610)
Screenshot (611)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 25, 2024
@Maleclypse Maleclypse merged commit b95288b into CleverRaven:master Jun 26, 2024
22 of 26 checks passed
@PatrikLundell PatrikLundell deleted the hunting_blind branch June 26, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants