Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Add Hy-Brasilean ambassadorial honor guard profession #74767

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jun 24, 2024

Summary

Mods "[Magiclysm] Add Hy-Brasilean ambassadorial honor guard profession"

Purpose of change

I wanted to add an "elven ranger"-style profession, but in a way that fits the Magiclysm lore.

Describe the solution

Add the Hy-Brasilean ambassadorial honor guard profession. They start with traditional elven equipment (cloak of elvenkind, boots of elvenkind, bow of elvenkind), archery skills, and social (since they had to deal with dignitaries at least tangentially). They were in America when the Cataclysm hit and now have to use their training to survive actual combat.

While they start with magical items, they don't have any magic, since they aren't actually elven forest ninjas, they're just supposed to make foreigners think they are. They also don't start with magical arrows, since cool archery demonstrations are riskier if your arrows explode or leave a cloud of poison gas behind. They do have one actual firearm since the months leading up to the Cataclysm were much more dangerous than previously.

I also added them to the helicopter crash scenario.

Describe alternatives you've considered

Testing

Profession appears and is selectable and starts with appropriate equipment.

Additional context

Learned today that Hy-Brasil and Brazil are totally unrelated words.

@Standing-Storm Standing-Storm changed the title [Magiclysm] Add Hy-Brasil ambassadorial honor guard profession [Magiclysm] Add Hy-Brasilean ambassadorial honor guard profession Jun 24, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Scenarios New Scenarios, balancing, bugs with scenarios Mods: Magiclysm Anything to do with the Magiclysm mod labels Jun 24, 2024
@github-actions github-actions bot requested a review from KorGgenT June 24, 2024 19:51
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Hy-Brasilean ambassadorial honor guard
  • You were a ceremonial guard for the Hy-Brasilean ambassador to the United States, equipped to bring to mind the elven forest warriors of old. You were trained in archery, since you had to use your bow to impress foreign dignitaries, but you never expected you'd actually have to take it into a real battle. Then the Cataclysm hit. The ambassador and most of your fellow guards are dead, and you'll probably never see home again, but hopefully your skills will keep you alive.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 24, 2024
@Maleclypse Maleclypse merged commit 1d2c114 into CleverRaven:master Jun 25, 2024
26 checks passed
@Standing-Storm Standing-Storm deleted the elven-special-forces branch June 25, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants