Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roofs to market stalls #74760

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Provide market stalls with some needed shade.

Describe the solution

Add roof chunks and nest them into the stalls.
Remove the strange open air roof layer.

Describe alternatives you've considered

Testing

Debug spawn 4 open markets in a square. Teleport to them and inspect them to verify the roof footprint matches the stalls' footprint. This ought to cover many variant, but not all (the 7*7 version didn't show up).
Screenshot (590)
Screenshot (591)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 24, 2024
@Maleclypse Maleclypse merged commit 9281795 into CleverRaven:master Jun 25, 2024
20 of 24 checks passed
@PatrikLundell PatrikLundell deleted the market_stall branch June 25, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants