Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mossberg 590M #74613

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Add Mossberg 590M #74613

merged 4 commits into from
Jun 18, 2024

Conversation

GuardianDll
Copy link
Member

Summary

Content "Added Mossberg 590M. Just look at this gun, it is ridiculous"

Purpose of change

Discussion about gun removing sparked me a bit, and i found the very existence of the gun to be fun

Describe the solution

Added ridiculous gun, it's mags, make itemgroup stuff

Testing

Walked around, shooted zeds with a gun, found mags

Additional context

image

Gunbroker as proof, but the gun was designed in 2018, and is still manufactured by Mossberg & Sons
image

And, just, look at this thing! They even left the tube mag untouched to cheapen the manufacturing!
image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Magazines Ammo holding items and objects. Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 16, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 17, 2024
Copy link
Contributor

@DoctorBoomstick DoctorBoomstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wacky; I can’t wait to find one in game. Glad to have more magazine-fed shotguns nocking about. On a side note, perhaps it would be a good idea to include your source for the magazine volumes in a JSON comment, as that seems to be the norm when browsing through other magazines.

data/json/items/gun/shot.json Outdated Show resolved Hide resolved
data/json/items/gun/shot.json Outdated Show resolved Hide resolved
data/json/items/magazine/shot.json Show resolved Hide resolved
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A classic Mossberg 590 pump-action shotgun, modified by the manufacturer to utilise box magazines.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Kantonine
Copy link
Contributor

Very nice! Can't wait to use this!

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 17, 2024
@kevingranade
Copy link
Member

So side note if you can't search completed items on gunbroker and you get 100+ hits with current postings that's fine, it's just if it's under 100 on current hits you'll need to bug someone to search for you (I'll do it if I'm around).

@Maleclypse Maleclypse merged commit 25727d8 into master Jun 18, 2024
20 of 24 checks passed
@GuardianDll GuardianDll deleted the mossberg_590m branch June 18, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Generic Guns Anything to do with Generic Guns Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants