Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roofs on roof buildings, add glass roof on entrance #74588

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

  • Add explicit roofs on rooftop buildings rather than relying on add_roofs magic.
  • Add glass roof on secret lab office building entrance.

Describe the solution

  • Add a layer for the roofs and hook it into the infrastructure.
  • Use the entrance roof from the building the lab is based on rather than open air.

Describe alternatives you've considered

Testing

Debug spawn facilities, teleport to them, examine them.
Screenshot (479)
Screenshot (480)
Screenshot (481)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 16, 2024
@Maleclypse Maleclypse merged commit aea035a into CleverRaven:master Jun 16, 2024
21 of 26 checks passed
@PatrikLundell PatrikLundell deleted the office_tower branch June 17, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants