Use std::string_view in mod_tracker #74565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Bionics
There's no reason for it to use std::string &
This is copy/pasted from the function, so just call the function.
anothersimulacrum
force-pushed
the
mod_tracker_string_view
branch
from
b1c7770 to
179e09b
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Cherry-pick some changes from #74514
Use string_view and appease clang-tidy on std::string_view.
Describe the solution
Use std::string_view.
Also, b1c7770 deduplicates some code.
Describe alternatives you've considered
Testing
See clang-tidy.
Additional context