Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit internal roofs to Karting #74550

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented Jun 15, 2024

Summary

None

Purpose of change

Add explicit internal roofs to karting rather than relying on add_roofs magic.

Describe the solution

Modify the JSON upper floor definition. Concrete floors was used to match building, rather than flat roof which add_roofs magic would provide (with walls doors, etc. giving other results).

Describe alternatives you've considered

  • Different floor material? I think concrete matches the building best.
  • Cover the racetrack office? It was designed with no roof...
  • Add windows overlooking the pool area.

Testing

Debug spawn building, teleport to it, inspect it.
Screenshot (467)
Screenshot (468)

Additional context

The code used is hacked to disable add_roofs in order to find missing roof definitions. This means the track office walls and the internal wall/door shown without roofs in the image will be covered by whatever roof those tiles place above them in the actual game, until add_roofs is disabled.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 15, 2024
@dseguin dseguin merged commit d15781d into CleverRaven:master Jun 15, 2024
26 checks passed
@PatrikLundell PatrikLundell deleted the karting branch June 15, 2024 14:42
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants