Remove legacy enum handling for and the extern list of field types #74543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
Procyonae
changed the title
Procyonae
force-pushed
the
RemoveExternFieldTypes
branch
2 times, most recently
from
2750ad2 to
5a30768
Compare
Remove remaining fd_null Simplify weird field type loading /tests Remove legacy_enum_id s Rest of /src Remove the list proper Merge weird nested function Make an early return earlier Sanity check some needless if checks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@Procyonae could you please resolve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Extern bad
Random ancient legacy handling bad
Describe the solution
Replaces the extern list with the preferred per cpp static const definitions
Removes the legacy id code that I unhooked in #74497
Changes some gross if statement chains to gross if else statement chains, will probably make a followup PR changing them to something nicer
Replaces all fd_null usages with field_type_str_id::NULL_ID()
Make ammo effect's aoe_field_type and trail_field_type string ids instead of int ids and not load as raw strings first
Describe alternatives you've considered
Testing
Additional context