Fix identifier check for more guns #74530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
|
"ZPAP Mini AK-style rifle" should be "ZPAP Mini AK-style pistol", it uses the handgun skill. |
anothersimulacrum
force-pushed
the
some-more-guns
branch
from
c6ab02c to
a6e5691
Compare
anothersimulacrum
force-pushed
the
some-more-guns
branch
from
a6e5691 to
8d485b1
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Remove testing blacklists.
Describe the solution
Change names, add variants, remove from blacklist.
Describe alternatives you've considered
Different names
Testing
tools/json_tools/gun_variant_validator.py -v -cin data/jsonAdditional context
If @Holli-Git can review, I would appreciate