Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display distance to mission objective as a real distance #74502

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

RenechCDDA
Copy link
Member

@RenechCDDA RenechCDDA commented Jun 13, 2024

Summary

Interface "Show actual real-world distance to mission objective"

Purpose of change

image

Describe the solution

Just do that

Describe alternatives you've considered

Testing

image
image
image
image

Additional context

due to how length_units converts we always get a meters/yards value unless it is perfectly divisible into kilometers. I wasn't going to risk touching that when the meters-->kilometers conversion is perfectly easy to do in your head just by looking at it.
(Yes, this IS much more difficult with imperial! Too bad, use a real measurement system! -Signed, American who uses metric)

IMPERIAL WINS AGAIN! GOD BLESS AMERICA!
-Signed, American (who uses metric 😢 )

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Missions Quests and missions Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` labels Jun 13, 2024
@RenechCDDA RenechCDDA force-pushed the REAL_distance_to_mission branch from b41f32f to 0bfd164 Compare June 13, 2024 05:50
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 13, 2024
@RenechCDDA RenechCDDA force-pushed the REAL_distance_to_mission branch from 0bfd164 to 9e9170c Compare June 13, 2024 05:55
@PatrikLundell
Copy link
Contributor

I'd prefer to get both real world distances AND game distances. This is especially relevant as game distances are rather loose with their real world connections (good luck trying to shoot at a 200m target at a shooting range).

@RenechCDDA
Copy link
Member Author

I updated the example images to be more clear. I did already force push it to displaying both.

@RenechCDDA
Copy link
Member Author

image

....Okay I guess this is my problem

@RenechCDDA RenechCDDA marked this pull request as draft June 13, 2024 06:51
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 13, 2024
@RenechCDDA RenechCDDA marked this pull request as ready for review June 13, 2024 08:26
@dseguin dseguin merged commit a0cbdbb into CleverRaven:master Jun 13, 2024
35 of 43 checks passed
@RenechCDDA RenechCDDA deleted the REAL_distance_to_mission branch June 13, 2024 20:39
@Consoleable
Copy link
Contributor

image

....Okay I guess this is my problem

As a citizen of the internet, how many bananas is that?

@PatrikLundell
Copy link
Contributor

It depends on the kind of banana...
However, it's about 38057 minimum length bananas of the Gros Michel or Cavendish sub-groups.

https://unece.org/fileadmin/DAM/trade/agr/meetings/ge.01/document/Codex%20bananas%20E.pdf

SurFlurer added a commit to SurFlurer/Cataclysm-DDA that referenced this pull request Aug 26, 2024
…tance_to_mission"

This reverts commit a0cbdbb, reversing
changes made to a9250ae.
?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants