Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add espadrilles #74490

Merged
merged 9 commits into from
Jun 16, 2024
Merged

Add espadrilles #74490

merged 9 commits into from
Jun 16, 2024

Conversation

BalthazarArgall
Copy link
Contributor

@BalthazarArgall BalthazarArgall commented Jun 12, 2024 •
edited
Loading

Summary

Content "Add espadrilles"

Purpose of change

We can now go to the beach yet our footwear selection is severely lacking in the beach compatible department. It also turns out that most of our sandals are of the innawood "bark and strings" variety.

Describe the solution

Add espadrilles to the game, stylish and perfect for the summer.

Describe alternatives you've considered

Testing

Spawned, worn, no issues.

Additional context

Closes #74247. 🎁 @Kantonine

Image for context:
640px-Alpargatas_(Espadrilles)_01

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 12, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 12, 2024
@BalthazarArgall BalthazarArgall marked this pull request as ready for review June 13, 2024 09:50
@BalthazarArgall
Copy link
Contributor Author

BalthazarArgall commented Jun 13, 2024 •
edited
Loading

Sorry for the last minute addition of xs/xl versions, and the errors they brought.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 13, 2024
@Kantonine
Copy link
Contributor

Thanks a ton for this!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 14, 2024
@BalthazarArgall
Copy link
Contributor Author

https://www.youtube.com/watch?v=jmrjjFUuvYQ you use rope to make the soles or you buy premade soles. https://www.adaspragg.com/2015/08/07/diy-espadrilles/

Alright, I think I'm done fixing the recipes, tell me what you think.

@Maleclypse Maleclypse merged commit ae7671a into CleverRaven:master Jun 16, 2024
22 of 23 checks passed
@BalthazarArgall BalthazarArgall deleted the Espadrilles branch June 28, 2024 15:22
@BalthazarArgall BalthazarArgall restored the Espadrilles branch June 28, 2024 15:22
@BalthazarArgall BalthazarArgall deleted the Espadrilles branch June 28, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Footwear: Espadrilles!
3 participants
@BalthazarArgall @Kantonine @Maleclypse