Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

natural rock-> floor/roof, adjusted destruction to match #74485

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

  • Change floor/roof from natural rock to actual floor/roof materials.
  • Match roof destruction to floor destruction.

Describe the solution

Adjust the JSON definitions to make sense, i.e. use real materials instead of natural rock floor, and match roof destruction to floor destruction.

Describe alternatives you've considered

Testing

  • Debug spawn special.
  • Teleport to it.
  • Inspect that the roof matches the floor (and that materials are reasonable for man-made buildings).
  • Do the above for both sites.

Additional context

When the floor is defined as being of the no-roof version, there probably shouldn't be a roof over it...

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 12, 2024
@dseguin dseguin merged commit 3c63989 into CleverRaven:master Jun 12, 2024
25 checks passed
@PatrikLundell PatrikLundell deleted the riverside branch June 12, 2024 17:28
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants