Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Add Spark to Esper scenario #74461

Merged
merged 23 commits into from
Jun 18, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jun 11, 2024

Summary

Mods "[Aftershock] Add Spark to Esper scenario"

Purpose of change

Adding another possible Esper type.

Describe the solution

Add the Spark (electrokinetic) profession to the Esper scenario, the Spark hobby matching the Whisper hobby, and appropriate powers to support them.

Also edit the Scenario so that the Esper does not know where the nearest town is.

Describe alternatives you've considered

Testing

Powers work, meditating on them puts XP in the right place, starting scenario works, Spark hobby is incompatible with the Whisper hobby.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft June 11, 2024 15:17
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Scenarios New Scenarios, balancing, bugs with scenarios Mods: Aftershock Anything to do with the Aftershock mod EOC: Effects On Condition Anything concerning Effects On Condition labels Jun 11, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jun 11, 2024
Standing-Storm and others added 13 commits June 11, 2024 10:18
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ion_eocs.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ion_eocs.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ion_eocs.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Jun 11, 2024
@github-actions github-actions bot added the Mechanics: Enchantments / Spells Enchantments and spells label Jun 14, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jun 14, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 14, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review June 17, 2024 19:07
@Maleclypse Maleclypse merged commit 9db05f4 into CleverRaven:master Jun 18, 2024
21 of 25 checks passed
@Standing-Storm Standing-Storm deleted the afs-esper-spark branch June 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants