-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Aftershock] Add Spark to Esper scenario #74461
Merged
Maleclypse
merged 23 commits into
CleverRaven:master
from
Standing-Storm:afs-esper-spark
Jun 18, 2024
Merged
[Aftershock] Add Spark to Esper scenario #74461
Maleclypse
merged 23 commits into
CleverRaven:master
from
Standing-Storm:afs-esper-spark
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Scenarios
New Scenarios, balancing, bugs with scenarios
Mods: Aftershock
Anything to do with the Aftershock mod
EOC: Effects On Condition
Anything concerning Effects On Condition
labels
Jun 11, 2024
data/mods/Aftershock/spells/psionics/electrokinesis_concentration_eocs.json
Outdated
Show resolved
Hide resolved
data/mods/Aftershock/spells/psionics/electrokinesis_concentration_eocs.json
Outdated
Show resolved
Hide resolved
data/mods/Aftershock/spells/psionics/electrokinesis_concentration_eocs.json
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Jun 11, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ion_eocs.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ion_eocs.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ion_eocs.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
label
Jun 11, 2024
github-actions
bot
added
the
Mechanics: Enchantments / Spells
Enchantments and spells
label
Jun 14, 2024
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Jun 14, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Aftershock
Anything to do with the Aftershock mod
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Scenarios
New Scenarios, balancing, bugs with scenarios
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Aftershock] Add Spark to Esper scenario"
Purpose of change
Adding another possible Esper type.
Describe the solution
Add the Spark (electrokinetic) profession to the Esper scenario, the Spark hobby matching the Whisper hobby, and appropriate powers to support them.
Also edit the Scenario so that the Esper does not know where the nearest town is.
Describe alternatives you've considered
Testing
Powers work, meditating on them puts XP in the right place, starting scenario works, Spark hobby is incompatible with the Whisper hobby.
Additional context