Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Graphical_Overmap mod + Add errorless mod removal #74457

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Jun 11, 2024

Summary

None

Purpose of change

The mod in general has been superceded by actual tileset overmap support
The look it used has been superceded by Larwick_Overmap
Anyone still using this is crazy

Describe the solution

Deletes the mod

Replaces the error if you load a mod that's not installed with a query to optionally remove it from the active mod list, with a set of removed mods that changes the message to make it clear that it's been removed and isn't a launcher etc problem.
Removes load_packs unusued return value rather than updating the return

Describe alternatives you've considered

Housing obsoleted mods in the repo indefinitely

On "No" having a second query to abort the load
Not differentiating recently removed mods and otherwise missing mods
Trying to make the removed mod list json in /data/core or something but that seems unnecessary

Testing

Started a world with MMA active, saved, deleted the mod, loaded, got the query and said no, saved, got the query and said yes, saved, didn't get the query as expected

Additional context

I'm glad we don't have to live with a menu that looks like this to achieve a cool overmap anymore ;D
image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 11, 2024
@Procyonae Procyonae marked this pull request as draft June 11, 2024 12:06
@Procyonae
Copy link
Contributor Author

Procyonae commented Jun 11, 2024

Actually adding proper error free removal for mods should be pretty easy, I'll look into adding that

Edit: Since this I remembered data/mods/replacements.json exists but I think providing an actual prompt rather than just automatically removing the mods is better so players with weird installs can tell when something's gone wrong

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Jun 11, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Mod %s has been removed, remove it from this world's modlist?
  • Mod %s not found in mods folder, remove it from this world's modlist?

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Procyonae Procyonae marked this pull request as ready for review June 11, 2024 13:23
@Procyonae Procyonae changed the title Remove Graphical_Overmap mod Remove Graphical_Overmap mod + Add errorless mod removal Jun 11, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 11, 2024
@dseguin dseguin merged commit 2a081fb into CleverRaven:master Jun 13, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants