-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Graphical_Overmap mod + Add errorless mod removal #74457
Conversation
Actually adding proper error free removal for mods should be pretty easy, I'll look into adding that Edit: Since this I remembered data/mods/replacements.json exists but I think providing an actual prompt rather than just automatically removing the mods is better so players with weird installs can tell when something's gone wrong |
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Summary
None
Purpose of change
The mod in general has been superceded by actual tileset overmap support
The look it used has been superceded by Larwick_Overmap
Anyone still using this is crazy
Describe the solution
Deletes the mod
Replaces the error if you load a mod that's not installed with a query to optionally remove it from the active mod list, with a set of removed mods that changes the message to make it clear that it's been removed and isn't a launcher etc problem.
Removes load_packs unusued return value rather than updating the return
Describe alternatives you've considered
Housing obsoleted mods in the repo indefinitely
On "No" having a second query to abort the load
Not differentiating recently removed mods and otherwise missing mods
Trying to make the removed mod list json in /data/core or something but that seems unnecessary
Testing
Started a world with MMA active, saved, deleted the mod, loaded, got the query and said no, saved, got the query and said yes, saved, didn't get the query as expected
Additional context
I'm glad we don't have to live with a menu that looks like this to achieve a cool overmap anymore ;D