-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a deconstruct query with item list #74440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be toggled with an option
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
[C++]
Changes (can be) made in C++. Previously named `Code`
<Bugfix>
This is a fix for a bug (or closes open issue)
<Enhancement / Feature>
New features, or enhancements on existing
labels
Jun 10, 2024
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jun 10, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 11, 2024
Drafting bc I've almost got the min max count/charges working |
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 11, 2024
Procyonae
force-pushed
the
DeconstructQuery
branch
from
June 12, 2024 08:42
2322878
to
443c972
Compare
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[C++]
Changes (can be) made in C++. Previously named `Code`
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
<Enhancement / Feature>
New features, or enhancements on existing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Deconstructing now prompts with potential items, can be toggled off in settings"
Purpose of change
Fixes #69848
Describe the solution
After you select a tile to deconstruct it prompts you with the items you can get and requires confirmation to start akin to the disassembly query.
Adds an option to disable this (screenshot of where the option is below)
Changes names/categories of the deconstructions to reflect that they also work on terrain
Updated QUERY_DISASSEMBLY message because it also applies to non butchery "B" disassembly (notably doesn't hook into item -> "D" disassembly though, I'll look into that)
I wanted to write some kind of function akin to Item_group::create() that would walk the group and write a map ofSnup helped me figure this out ^^itypes
andnumeric_interval<int>
s corresponding to the minimum and maximum number of that item possible to get from the group but that's a bit beyond me today, this still seems like a big improvement on having to solely rely on the json or hhg to know what you can get in advance.Describe alternatives you've considered
Not adding the query to simple deconstruct or making the option have 3 values, true, false and complex only
Not adding temporary handling for the number of items instead just always doing "- plural" or "- singular"Adding a bool to partial_con to determine whether to do turn is run instead of repeated counter == 0 checks
Ordering the item list
Testing
Tested that selecting
Yes
starts the construction as expected with no further prompts including on resumingTested that selecting
No
cancels the construction as expectedTested the yields were within the bounds shown by the query for a console inc charges
Tested that the potential skill practise message displays/doesn't display as expected
Additional context
Setting location:
Example query: