Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mods] Aftershock/MoM compatibility Fix #74438

Closed

Conversation

Standing-Storm
Copy link
Contributor

Summary

Bugfixes "[Mods] Aftershock/MoM compatibility"

Purpose of change

I didn't realize that when two mods are loaded on the same level (i.e. when neither is dependent on the other), EoCs don't overwrite, they clash and cause an error, making it impossible to even load a game that has both MoM and Aftershock enabled.

Describe the solution

Change some EoC IDs and set some effects to draw on non-inline enchants to allow both mods to load, as well as differentiate Aftershock's telepathic damage.

Describe alternatives you've considered

Testing

Game now loads.

Additional context

Obviously there's going to be a lot of thematic clash, but at least people can load their saves now.

Only the last-loaded mods' psi practice recipes work since both mods add a practice category. Not sure how to solve that one.

@Standing-Storm Standing-Storm changed the title [Mods] Aftershock/MoM compatibility [Mods] Aftershock/MoM compatibility Fix Jun 10, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels Jun 10, 2024
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Jun 10, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jun 10, 2024
@Standing-Storm Standing-Storm deleted the afs-mom-compat branch June 10, 2024 21:55
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant