Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mi-go roofs #74410

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fixed mi-go roofs #74410

merged 1 commit into from
Jun 11, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Add explicit roofs to mi-go structures rather than relying on roof magic.

Describe the solution

  • Split the "clever" merging of level 1 and 2 of the mi-go camp into separate structures.
  • Added the missing level 1 roof of the western half of the camp.
  • Added the missing roof of the level 2 building.
  • Adjusted level 2 marginally (wall+floor -> platform outside of building).
  • Added roof to the mi-go portal structure.

Describe alternatives you've considered

Add fluff to the roofs.

Testing

Adjusted definition, debug spawned the structure, teleported to it and inspected it.
Repeat for the second structure.
Screenshot (445)
Screenshot (446)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 9, 2024
@Maleclypse Maleclypse merged commit 162bc64 into CleverRaven:master Jun 11, 2024
22 of 26 checks passed
@PatrikLundell PatrikLundell deleted the migo branch June 11, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrikLundell @Maleclypse