Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small lighthouse #74393

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Small lighthouse #74393

merged 1 commit into from
Jun 11, 2024

Conversation

harakka
Copy link
Member

@harakka harakka commented Jun 8, 2024

Summary

Content "Small lighthouse"

Purpose of change

The currently existing lighthouse map felt too big and fancy for my humble tastes, so here's a smaller one. It's my first map so feedback welcome on how to do things better.

Describe the solution

This is a smallish late 1800s lighthouse of stone and mortar construction, still in service up to the cataclysm, renovated to use a modern replacement electric light source. However the generator mysteriously broke so it's no longer functional. Attached to the lighthouse is a small two story structure for storage and to serve as temporary quarters of the (now obsolete) lighthouse keeper and technicians servicing navigational aids in the area.

The map is added as alternative to starts which use the current lighthouse.

This is heavily based on curstwist's lighthouse. Terrains are heavily copypasted from their looks-likes.

TODO before undrafting
  • whitewashed stone and mortar terrain
  • palettize
  • upstairs food and tools storage
  • storage shed for diesel and firewood
  • wrecked generator
  • electricals on the ground level of the lighthouse
  • more trash indoors
  • outhouse
  • better ground cover for the island
  • proper stone flooring terrain

Describe alternatives you've considered

Modifying the existing lighthouse, but I think it's fine as a bigger one that has been turned into fancy housing.

Testing

Going through lots of A Safe Place starts and looking around

Additional context

Screenshots should be up to date minus some roof terrain changes.

Screenshot_20240609_195129

Screenshot_20240609_195157

Screenshot_20240609_195213

Screenshot_20240609_195653

Screenshot_20240609_195638

Screenshot_20240609_195623

Possible additions to this in a future PR
  • add this to oceans and lake/ocean shores
  • appliance for the light for you to fix and power
  • achievement if you do fix it as said technician
  • navigation aid technician start
  • better work boat
  • ɴᴏ ᴏɴᴇ ʟɪᴠᴇs ᴜɴᴅᴇʀ ᴛʜᴇ ʟɪɢʜᴛʜᴏᴜsᴇ

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Scenarios New Scenarios, balancing, bugs with scenarios Mods: Magiclysm Anything to do with the Magiclysm mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 8, 2024
@Vaskritaya
Copy link
Contributor

Could make sense to have this spawn coastal to oceans if that's mechanically possible. Probably out of scope since it would be a whole different map, but felt it was worth mentioning for the future since more flavor for oceans is always good.

@harakka
Copy link
Member Author

harakka commented Jun 8, 2024

I'll probably look at adding this to oceans after #72866 is done.

@PatrikLundell
Copy link
Contributor

The bottom level looks like it has a natural stone floor, which isn't suitable for a man made structure. I may be wrong about the material, though.

@harakka
Copy link
Member Author

harakka commented Jun 9, 2024

That's the "proper stone flooring terrain" item on the todo list.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 9, 2024
@harakka harakka marked this pull request as ready for review June 9, 2024 17:46
@harakka harakka force-pushed the lighthouse_small branch from 1a44253 to b1e866b Compare June 9, 2024 18:28
@github-actions github-actions bot requested a review from KorGgenT June 9, 2024 19:45
@Maleclypse Maleclypse merged commit f11d8e8 into CleverRaven:master Jun 11, 2024
23 of 27 checks passed
@Maleclypse
Copy link
Member

Very cool and neat looking! I went ahead and asked in tileset discord about using the mon_turret_searchlight as a filler sprite for the the lighthouse light.

@harakka harakka deleted the lighthouse_small branch June 11, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants