Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy npc_class_id handling and extern list #74354

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Remove legacy npc_class_id handling and extern list #74354

merged 1 commit into from
Jun 7, 2024

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Jun 6, 2024 •
edited
Loading

Summary

None

Purpose of change

8+yr old migration code probably isn't needed anymore /s
Extern evil

Describe the solution

Describe alternatives you've considered

Testing

Game compiles and loads and loads existing saves fine and tests compile

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership Missions Quests and missions Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 6, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 7, 2024
@dseguin dseguin merged commit b03844f into CleverRaven:master Jun 7, 2024
29 checks passed
feinorgh pushed a commit to feinorgh/Cataclysm-DDA that referenced this pull request Jun 8, 2024
@Procyonae @feinorgh
Remove legacy npc_class id handling and extern list (CleverRaven#74354)
bf1d36b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RenechCDDA RenechCDDA RenechCDDA left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Procyonae @RenechCDDA @dseguin