Random legacy code cleanup #74351
Merged
Random legacy code cleanup #74351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
Procyonae
commented
Jun 6, 2024
github-actions
bot
added
Code: Tests
|
Is the clang failure yours or something else? |
Procyonae
force-pushed
the
RandomLegacyCodeCleanup
branch
from
aae0413 to
eb599d6
Compare
Brambor's, they fixed it since, I were just waiting for the fix to merge to restart the tests |
github-actions
bot
removed
the
BasicBuildPassed
Procyonae
force-pushed
the
RandomLegacyCodeCleanup
branch
from
eb599d6 to
717d14b
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Dead code bad
All marked for removal
Describe the solution
Describe alternatives you've considered
More/Less in one PR
Testing
Tested with a new save post save load and a 0.H branch save provided by harakka with no relevant errors
Additional context