Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to some snippets in data/json/npcs/talk_tags.json #74327

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Jun 5, 2024

Summary

None

Purpose of change

Add context to some talk tags to separate them from their item/monster/furniture name counterpart.

Describe the solution

Do it.

Describe alternatives you've considered

Not doing it.

Testing

The game loads.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 5, 2024
@NetSysFire NetSysFire added the Translation I18n label Jun 5, 2024
@Qrox Qrox marked this pull request as draft June 6, 2024 08:31
@Qrox Qrox marked this pull request as ready for review June 9, 2024 17:25
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 9, 2024
@Maleclypse Maleclypse merged commit 73690af into CleverRaven:master Jun 11, 2024
22 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants