[Aftershock] Remove Habitat Block palette and expand Habitat Structure palettes. #74326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Removes the habitat block palette introduced in my last PR and expands the palettes in habitat structure."
Purpose of change
It was requested that I not create additional palettes and instead focus on using and expanding existing ones when possible.
Describe the solution
This PR removes the palette I added in my last PR and expands the existing ones with the entries I most often used. As a compromise two smaller palettes were added called Habitat Exterior and Habitat Life Support. Habitat Exterior holds mainly floors that don't really fit with habitat structure and are more suited for outside habitats as the name implies. Habitat Life support was added because I was bothered I couldn't easily access the life support furniture when using the residential palette. Since the Life Support furniture was in the mech palette which overlapped and several nasty ways with the residential one. The Life Support palette was made so as not to overlap with any other palettes so it can be used with either mech or residential palettes as needed.
I also briefly flicked back over to my previous constructions to remove any conflicts caused by the new additions to the palettes. As well as rebind any locally defined furniture's/terrains to the slots specifically left open for them to use to avoid future problems.
Describe alternatives you've considered
The Life Support and Habitat External palettes both use special ASCII characters. These would be the only palettes I know of in the Habitat structure file to do so. If this is undesirable it's probably possible to rebind these keys to something else. But it would likely cause overlap between palettes which I would like to avoid.
I considered not separating the external palette from the main structure palette. However I felt since the external palette reserves some special characters. It may be desirable to be able to leave it off in certain circumstances. So I separated them.
It's technically possible to continue using the mech palette for Life support furniture. But since the storage board and water heater overlap you to have locally re bind one or both and be mindful of palette ordering. Which is a pain.
When breaking apart the habitat block palette I strongly considered creating either a "Habitat Commercial" palette or several themed shop palettes "Habitat Library", "Habitat Gun Store", ect... Ultimately I locally defined all the item spawning furniture in their respective mapgen. Since that's currently how it done everywhere else in the mod. (That I can see.) But there is some merit to creating palettes for item spawning furniture as well. Since it might make balancing loot spawns and changing out item groups easier in the future.
Testing
I re-visited all the structures I added to verify they were spawning correctly. I also quickly visited the other structures within the mod to verify they were spawning correctly as well.
Additional context