-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove PATH_AVOID_DANGER_2 #74322
Merged
Maleclypse
merged 3 commits into
CleverRaven:master
from
nornagon:remove-avoid-danger-2
Jun 11, 2024
Merged
remove PATH_AVOID_DANGER_2 #74322
Maleclypse
merged 3 commits into
CleverRaven:master
from
nornagon:remove-avoid-danger-2
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
<Documentation>
Design documents, internal info, guides and help.
label
Jun 4, 2024
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Code: Tests
Measurement, self-control, statistics, balancing.
[C++]
Changes (can be) made in C++. Previously named `Code`
labels
Jun 4, 2024
github-actions
bot
added
Monsters
Monsters both friendly and unfriendly.
[Markdown]
Markdown issues and PRs
labels
Jun 4, 2024
github-actions
bot
added
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods: Aftershock
Anything to do with the Aftershock mod
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods: No Hope
Relating to the mod No Hope
Mods: Defense Mode
Anything to do with the Defense Mode mod
Mods: TropiCataclysm 🌴
Having to do with the tropical region mod for DDA.
Mods: Desert Region
Anything relating to the Desert Region mod
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods: Mind Over Matter
labels
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @LyleSY @Fris0uman @Standing-Storm @Night-Pryanik
github-actions
bot
added
the
<Bugfix>
This is a fix for a bug (or closes open issue)
label
Jun 4, 2024
nornagon
force-pushed
the
remove-avoid-danger-2
branch
2 times, most recently
from
June 5, 2024 00:00
d3153f2
to
fb83211
Compare
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Jun 5, 2024
nornagon
force-pushed
the
remove-avoid-danger-2
branch
from
June 5, 2024 00:02
fb83211
to
c6217e5
Compare
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Jun 5, 2024
test failure appears to be unrelated. |
chaosvolt
added a commit
to chaosvolt/cdda-tankmod-revived-mod
that referenced
this pull request
Jun 11, 2024
Update monsterflag broken by CleverRaven/Cataclysm-DDA#74322 Also removed a redundant flag on the tankbot
chaosvolt
added a commit
to chaosvolt/cdda_medieval_mod_reborn
that referenced
this pull request
Jun 11, 2024
Fix monsterflag changed by CleverRaven/Cataclysm-DDA#74322
chaosvolt
added a commit
to chaosvolt/nocts_cata_mod
that referenced
this pull request
Jun 11, 2024
Fixes monsterflags changed by CleverRaven/Cataclysm-DDA#74322
chaosvolt
added a commit
to chaosvolt/cdda-arcana-mod
that referenced
this pull request
Jun 11, 2024
Fixes things broken by CleverRaven/Cataclysm-DDA#74322 Fixes #433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Tests
Measurement, self-control, statistics, balancing.
<Documentation>
Design documents, internal info, guides and help.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Mods: Aftershock
Anything to do with the Aftershock mod
Mods: Defense Mode
Anything to do with the Defense Mode mod
Mods: Desert Region
Anything relating to the Desert Region mod
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods: Mind Over Matter
Mods: No Hope
Relating to the mod No Hope
Mods: TropiCataclysm 🌴
Having to do with the tropical region mod for DDA.
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Monsters
Monsters both friendly and unfriendly.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Monsters with PATH_AVOID_DANGER flag will more reliably avoid fire and other dangerous fields"
Purpose of change
Continuing @actual-nh's work from #50343, I've removed the PATH_AVOID_DANGER_2
flag. Its functionality is replaced by PATH_AVOID_DANGER and
{ "path_settings": { "avoid_traps": true, "avoid_dangerous_fields": true } }
.Describe the solution
The only new player-observable behavior here should be that monsters with the
"avoid_dangerous_fields" path setting will now actually avoid fire and other
dangerous fields during pathfinding.
Describe alternatives you've considered
Testing
Additional context