Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the Charger Pistol #74321

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Adds the Charger Pistol #74321

merged 6 commits into from
Jun 7, 2024

Conversation

Holli-Git
Copy link
Contributor

Summary

Content "10/22 Pistol"

Purpose of change

The charger is a silly lil gun and would be nice to see in the cataclysm.

Describe the solution

Adds it

Describe alternatives you've considered

Not adding it

Testing

image
Spawns, roughly 1:10 ratio of chargers to 10/22s judging from gunbroker/

Additional context

image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 4, 2024
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. Mods: Generic Guns Anything to do with Generic Guns Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) labels Jun 4, 2024
@github-actions github-actions bot requested a review from I-am-Erk June 4, 2024 22:37
@John-Candlebury
Copy link
Member

I thought we were getting #15713 back for a moment lmao.

@Holli-Git
Copy link
Contributor Author

No, sorry, just something even better

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 5, 2024
@Maleclypse Maleclypse merged commit 9461bb9 into CleverRaven:master Jun 7, 2024
20 of 24 checks passed
feinorgh pushed a commit to feinorgh/Cataclysm-DDA that referenced this pull request Jun 8, 2024
@Holli-Git @feinorgh
Adds the Charger Pistol (CleverRaven#74321)
a2e60c5 
* Add the gun

* Add to item groups

* Readjust commonality

* Adds to item_demographics

* Adds mod compat

* Updates skill used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@I-am-Erk I-am-Erk Awaiting requested review from I-am-Erk

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Generic Guns Anything to do with Generic Guns Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Holli-Git @John-Candlebury @Maleclypse