Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Copper Wire Deconstructions #74296

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

TheMurderUnicorn
Copy link
Contributor

Summary

Balance "Adjust Copper Wire Deconstructions"

Purpose of change

As pointed out in #74278 copper wire did not disassemble into raw copper wire, it instead went straight to raw copper. This meant there was no way to mass strip wire and convert it and just from a common sense perspective, it made sense to have the middle ground of converting to raw copper wire. Additionally, strip time was 2m per single piece of copper wire, which is just absurd given how small they are.

Describe the solution

Essentially:

  • Copper wire converts to raw copper wire, 8 seconds each wire, requires cutting
  • Raw wire converts to copper, 1 s each (raw wire is effectively raw copper, and their weight difference is negligible)
  • And just for the sake of explanation there's no way to cheese this to get extra copper. IE: making wire from scratch costs 200 copper effectively and you get 182 back if you were to then disassemble it all.

Describe alternatives you've considered

Adding some sort of plastic to the disassembly as per the comment that exists with the entry (but its too tiny to even give plastic chunks)
Adjusting the weight of copper wire/raw copper in an effort to balance their disassemblies (what a terrible idea this would have been, didnt do that, obviously)

Testing

Made sure it all worked and converted properly, checked that the time requirement is working properly.

Additional context

It was pointed out in the initial issue that I'll link here in a second that the weight of copper v copper wires is not perfect. IE: you're converting wire into slightly more weight of copper. But since we're working with such tiny masses, there's no way to easily fix this, and since copper IS the smallest form of copper we have, there is no alternative. I do not have an issue with these slightly fudged numbers, but someone else might.

Unless they point something out, this should closes #74278

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Bugfix> This is a fix for a bug (or closes open issue) Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 3, 2024
@osuphobia
Copy link
Contributor

#74278 (comment)
Maybe we should make copper_wire a choice in some recipes, like chunk of coppper, chunk of bronze, and copper rod.

@Karol1223
Copy link
Contributor

However it does look like this would be creating a half a gram of copper out of thin air each round.

@Maleclypse I double checked the recipe chain, and although this specific step does generate mass, if you were to craft it it'd still be a net loss, since there's huge mass losses at the copper rod step -> not possible to cause infinite copper generation by this

Avoiding mass generation is important but I'm not sure where my stance on this one is since it's extremely minimal and doesn't generate resource farms.

@Maleclypse Maleclypse merged commit 5cf8042 into CleverRaven:master Jun 4, 2024
22 of 26 checks passed
@Maleclypse
Copy link
Member

Karol confirmed no infinite gain farm possible so I’m good with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between copper wire and raw copper wire
4 participants