Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provided scrap yard with roofs #74289

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented Jun 3, 2024

Summary

None

Purpose of change

Provide the occupied scrap yard with uniform explicit roofs, rather than the hodgepodge roof magic produces.

Describe the solution

Defined a roof layer and linked it into the structure.

Describe alternatives you've considered

  • Define roofs for the weird metal walls. However, I think they really shouldn't have any roofs, and so they'd be improved when (or if) the roof magic is removed.
  • Add a cooking facility and a chimney/vent pipe if it wasn't a brazier. It probably would be a brazier, given the makeshift nature of the other things done to make living quarters out of the site.
  • Add roof decorations (A/C unit, etc.)
  • Add gutters.

Testing

Debug spawned the scrap yard, teleported to it, and examined it.
Screenshot (431)
Screenshot (432)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 3, 2024
@Maleclypse Maleclypse merged commit c0e803d into CleverRaven:master Jun 4, 2024
27 checks passed
@PatrikLundell PatrikLundell deleted the scrap_yard branch June 4, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants