use local coordinates instead of global in avatar::rebuild_aim_cache() #74287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #74111
Feed relative coordinates into an operation that uses relative coordinate calculations, rather than global coordinates.
Describe the solution
Pass the just computed local coordinates into calc_steadiness rather than the global one fed to rebuild_aim_cache.
Describe alternatives you've considered
Continue to wait for someone to respond to #74111.
Testing
It compiles. I have no idea how to test it.
Additional context
It doesn't seem to be hugely important that most steadiness calculations are against targets extremely far away, but it's possible correcting the code might result in a faster aim when the target is actually considered to be nearby.