Stop showing suffix of vehicle if link needs reeling #74280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Bobtron
changed the title
github-actions
bot
added
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Stop showing suffix of vehicle in overextended link"
Purpose of change
Fixes #73859
Most basic fix that adds a condition to skip the code which adds the suffix. Ideally we should overhaul the needs_reeling state so that once a link overextends, the link is treated like it has no links
Describe the solution
Skips the line of code which appends the suffix shown in the issue. No logic changes etc.
Describe alternatives you've considered
Testing
Recreated scenario raised in the issue, and verified that the suffix no longer shows. Stepped through the code which is triggered on link overextension/link usage, and verified that nothing else is changed.
Additional context