Clean up item_demographics #74277
Closed
Clean up item_demographics #74277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
<Bugfix>
Holli-Git
force-pushed
the
add_mk4_testmod
branch
from
e7dde72 to
b815c21
Compare
github-actions
bot
added
the
BasicBuildPassed
github-actions
bot
removed
BasicBuildPassed
|
Closing because it seems to be benign and not very useful, and I'm going to change more guns anyways. May open it back up in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Trim item_demographics"
Purpose of change
item_demographics had a few guns that didn't exist and needed a few that did, this fixes it.
Describe the solution
Removes the non-existent guns, adds the new ones.
Describe alternatives you've considered
Just adding the new ones
Testing
How would I test this?
Additional context
Can we please have a test for adding new guns, to make sure they're added to item_demographics? Or does it not matter this much? Does removing non-existent guns as a whole do anything? Please tell me.