Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amphibians Audit #74240

Closed
wants to merge 14 commits into from
Closed

Amphibians Audit #74240

wants to merge 14 commits into from

Conversation

TheSaddestGoomba
Copy link
Contributor

@TheSaddestGoomba TheSaddestGoomba commented Jun 1, 2024

Summary

None

Purpose of change

To clean-up and update the frog and tadpole creatures and their implementation. I've learned quite a bit since my first PRs and plan to put that to use here. Please voice any suggestions for changes I can make with this PR. I don't frequent the discord but will search through for any additional feedback.

Describe the solution

  • Move Zed Frogs to their own JSON
  • Cleanup MONSTER_GROUPS
  • Condense redundant tadpoles and eggs
  • Update Flags:
    • KEENNOSE -Not applied, frogs have excellent olfactory abilities but do not hunt with them.
    • RANGED_ATTACKER -Applied, they always should have had this
    • WARM -Applied to all larger than natural frogs
    • CORNERED_FIGHTER -Applied to most (excludes treefrogs and 'big' frogs with other natural defenses)
    • EATS -Applied to all along with EAT_CARRION special attack, and a stomach_size
  • Complicate factions for in-fighting/cannibalism
    • Now test it
  • Adjust aggro/morale
  • Individuate egg spoil times
  • Add giant eggs to recipes
  • Add 'Jumbo Frog's Legs' and recipes
  • Recalculate volumes, weights, and densities
  • Revisit descriptions and names
  • Combat Tests and Adjustments
    • Convert cooldowns to 'math'
    • Audit special attacks & abilities
    • Combat Tests
    • Difficulty ratings
    • Tweak numbers
  • More detailed spawning (seasons, biomes, group behavior, time since cataclysm)
  • Give Z frogs some few direct spawns

Testing

None as of yet

Additional context

Relevant to: #67029

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 1, 2024
@worm-girl
Copy link
Contributor

I notice a question mark next to cornered_fighter, did you have a question about how it's supposed to work or are you just not sure about adding it?

@TheSaddestGoomba
Copy link
Contributor Author

I notice a question mark next to cornered_fighter, did you have a question about how it's supposed to work or are you just not sure about adding it?

I believe I understand it's function. I'm just unsure if/when it would be appropriate. Likely case-by-case, which ties into another thing I should include: aggro/morale.

'Warm' I just need to do some research. I presume there's a size threshold where they would produce more heat and be visible through thermal.

@worm-girl
Copy link
Contributor

I believe I understand it's function. I'm just unsure if/when it would be appropriate. Likely case-by-case, which ties into another thing I should include: aggro/morale.

Aggro and morale are super finicky. If you look at the black bear, it's really badly set up and usually just stands there "tracking" while you slowly beat it to death until it gets to around 75% HP and tries to flee.

Cornered_fighter won't fix that issue. It only affects critters who are actually in the fleeing state. It's best used for monsters that are supposed to run under certain conditions, but could unintentionally be trivialized by this. A good example is roaches - I made most of them flee in light, but if a hostile comes close and they can't escape, they'll turn and fight back rather than continuing to run forever.

@github-actions github-actions bot added the Spawn Creatures, items, vehicles, locations appearing on map label Jun 11, 2024
-Adds EAT flag, EAT_CARRION special attack, and a "stomach_size" to each abstract for oversized frogs.
-Also adds the WARM flag to each abstract as frogs this size wouldn't be able to blend into the environment under thermal imaging.
-Gives the "CORNERED_FIGHTER" flag to the 'giant' and 'mega' abstracts, and only the 'big' bullfrog and toad.
-Also gives them all the "RANGED_ATTACKER" flag which they always should have had for their tongue pull.
Based number changes on #74990
@github-actions github-actions bot added the Monsters Monsters both friendly and unfriendly. label Jul 13, 2024
Add 4 new frog sub-factions:
-One for large frogs that want to eat everything
-One for more passive mutant frogs that won't start fights with every insect
-One each for the foul and static mutant families
@TheSaddestGoomba TheSaddestGoomba deleted the amphib-audit branch September 23, 2024 15:38
@TheSaddestGoomba TheSaddestGoomba mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants