Add npc_loc_relative mutator #74219
Merged
Add npc_loc_relative mutator #74219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames loc_relative_u to u_loc_relative in line with every other EoC thing
github-actions
bot
added
<Documentation>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
|
test is here, so i suspect this PR is good to go |
github-actions
bot
added
json-styled
GuardianDll
force-pushed
the
NPCLocRelative
branch
from
7b21fca to
4b69199
Compare
GuardianDll
force-pushed
the
NPCLocRelative
branch
from
4b69199 to
b445a1a
Compare
GuardianDll
force-pushed
the
NPCLocRelative
branch
from
4bb4a9e to
2e6b1e3
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Kind of solves #74168
Describe the solution
After talking with Standing-Storm the main issue with #74168 is that you could only check the alpha talkers location so this adds a beta talker version (with the same syntax). I might also add the requested conditional in #74191 for discoverability and succinctness but this is more generally useful and is trivial so seems like a good thing to add regardless.
Describe alternatives you've considered
Fully splitting mutators into u_/npc_ but this appears to be the only one that uses talkers currently
Just calling it loc_relative and allowing a bool to make it use beta talker but that's uglier
Testing
Waiting on me writing a simple test EOC
Additional context