Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added chimney/vent pipe to shelter #74186

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Added chimney/vent pipe to shelter #74186

merged 1 commit into from
Jun 1, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Provide the shelter base camp with a chimney/vent pipe with its fireplace/wood stove.

Describe the solution

Add the corresponding JSON entries.

Describe alternatives you've considered

Testing

  • Loaded suitable save.
  • Debug spawned shelter.
  • Walked to the shelter and created a shelter base camp.
  • Spawned items and built the fireplace.
  • Checked the construction looked as expected.
  • Repeated the above but but the wood stove instead.
    Screenshot (415)
    Screenshot (416)
    Screenshot (417)
    Screenshot (418)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 30, 2024
@dseguin dseguin merged commit 73a45ff into CleverRaven:master Jun 1, 2024
26 checks passed
@PatrikLundell PatrikLundell deleted the shelter branch June 1, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrikLundell @dseguin