[Xedra Evolved] Update Undine water-checking EoCs to use test_eoc
#74179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Xedra Evolved] Update Undine water-checking EoCs to use
test_eoc"Purpose of change
Big lists of terrain and OMT ids are best kept in a single location
Describe the solution
Replace the individual conditions with
test_eocs in a central location. Use the same cross OMT then set variable as in the Homullus PR, to prevent conditions from running every second.Describe alternatives you've considered
Testing
It works.
Additional context