cache available recipe list in craft menu

[mischief]

Summary

Performance "cache available recipe list in craft menu"

Purpose of change

when filling in the recipe result pane with information about derived crafts, get_group_available_recipes and get_available_nested is called every time the ui is navigated. this makes it slow to scroll through the recipes or batch craft list, and i don't think is necessary since the available recipes aren't changing while the menu is open.

Describe the solution

stash the available recipes in the character for reuse and then invalidate the list once we exit the craft menu.

Describe alternatives you've considered

Testing

for me, this makes the craft menu much more responsive, especially on debug/non-lto builds where it is not optimized well.

Additional context

i tried this just as a hack, since i am new to the code, and there is likely a cleaner solution 😀

[RenechCDDA]

Implementation looks short and sweet to me, but maybe consider making the cache private with a getter?

[mischief]

@RenechCDDA PTAL. i've just used the turn counter to invalidate the cache, and don't cache in the tests to avoid the test show_available_recipes_with_item_as_an_ingredient failing.

[RenechCDDA]

@RenechCDDA PTAL. i've just used the turn counter to invalidate the cache, and don't cache in the tests to avoid the test show_available_recipes_with_item_as_an_ingredient failing.

I am late but this looks fine too! Thanks for the PR