-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ammo_effects can cast spells #74167
Merged
Merged
Ammo_effects can cast spells #74167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Changes (can be) made in C++. Previously named `Code`
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
<Enhancement / Feature>
New features, or enhancements on existing
json-styled
JSON lint passed, label assigned by github actions
labels
May 29, 2024
Magic gun go! |
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Mods: Aftershock
Anything to do with the Aftershock mod
Mechanics: Enchantments / Spells
Enchantments and spells
labels
May 30, 2024
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
May 30, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
<Enhancement / Feature>
New features, or enhancements on existing
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Aftershock
Anything to do with the Aftershock mod
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Allow ammo effects to cast spells"
Purpose of change
Allow creating more complex ammo with JSON alon by integrating the spell system into ammo effects.
Should be usefull for monster stuff and mods.
Describe the solution
Any ammo effect can list a single spell that will be cast at the projectiles impact point using the "spell_data" field. The shooter is considered as the caster.
Also adds a "test" voltaic rifle to aftershock that uses this functionality.
Describe alternatives you've considered
Allow ammo effects to cas EOC using both the shooter and the target, although that was more complex and not necessary for what I wanted.
Testing
Used the Archangel ENR added with this PR, shot normal weapons to no errors.