Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ammo_effects can cast spells #74167

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

John-Candlebury
Copy link
Member

@John-Candlebury John-Candlebury commented May 29, 2024

Summary

Features "Allow ammo effects to cast spells"

Purpose of change

Allow creating more complex ammo with JSON alon by integrating the spell system into ammo effects.
Should be usefull for monster stuff and mods.

Describe the solution

Any ammo effect can list a single spell that will be cast at the projectiles impact point using the "spell_data" field. The shooter is considered as the caster.

Also adds a "test" voltaic rifle to aftershock that uses this functionality.

Describe alternatives you've considered

Allow ammo effects to cas EOC using both the shooter and the target, although that was more complex and not necessary for what I wanted.

Testing

Used the Archangel ENR added with this PR, shot normal weapons to no errors.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions labels May 29, 2024
@adamkad1
Copy link
Contributor

Magic gun go!

@John-Candlebury John-Candlebury marked this pull request as ready for review May 30, 2024 02:48
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Mods: Aftershock Anything to do with the Aftershock mod Mechanics: Enchantments / Spells Enchantments and spells labels May 30, 2024
@github-actions github-actions bot requested a review from Maleclypse May 30, 2024 03:38
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • W3310 Archangel ENR
  • W3310 Archangel ENRs

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 30, 2024
@dseguin dseguin merged commit 7925627 into CleverRaven:master May 30, 2024
30 of 38 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 30, 2024
@John-Candlebury John-Candlebury deleted the afs-fusion-gun branch May 30, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants