Solving issue of size #74160
Solving issue of size #74160
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
[JSON]
| @@ -203,16 +203,19 @@ static units::volume size_to_volume( creature_size size_class ) | |||
| // e.g. max tiny size is 7500, max small size is 46250, we return | |||
| // 46250+7500 / 2 - 1_ml = 26875_ml - 1ml | |||
| // This is still stupid and both of these functions should be merged into one single source of truth. | |||
|
|
|||
| //Updated Calculation Because this one seems off | |||
There was a problem hiding this comment.
I'm not sure how you've determined it "seems off", but your math is just plain incorrect.
Max tiny size is 7500ml, max small size is 46250, the difference is (alternatively) represented as 38750, therefore the midpoint between the two is 7500 + (38750 / 2) = 7500 + 19375 = 26875, as calculated. 26875 is 19375 away from 7500, and 19375 away from 46250.
There was a problem hiding this comment.
I incorrectly expressed myself my point was more of taking half of max volume as an average volume for size as it looked a bit better to me (and for Huge I took it min value as it is as far as i can see the only option for mutated characters to still be able to use vehicles
There was a problem hiding this comment.
If you belive that this is inappropriate solution i will change it to previous values.
github-actions
bot
added
the
BasicBuildPassed
|
This PR seems to fundamentally misunderstand the size system and misattributes a bug with the cramped vehicle effect ( caused by #74004 ) to a trait that has nothing to do with the issue. The bug is currently affecting all characters and afaik a fix is being worked on by RenechCDDA. As the person who added the Very Tall mutation, its entire purpose was to add the LARGE flag to chargen. Large characters are not "cow and horse sized", they are just humans with mundane gigantism, 6'6" and up. Removing LARGE from the mutation would remove its sole reason for existing. Huge characters are cow and horse sized, but you can't select huge traits in chargen. But that's all irrelevant because the trait has nothing to do with the issue, it's affecting all characters. Creature sizes are not something that should be arbitrarily adjusted as they interact with a huge number of mechanics and would break many things, especially not because someone thinks the math "feels off". Changing them creates a ton of work downstream and the burden of proof for bad math should be quite high. As an aside, Kevin has suggested removing the Very Tall trait entirely and I'm inclined to agree, mostly because it leads to a lot of misunderstandings like this one. Very Short causes less confusion so I don't see as much of an issue there. |
|
Apologies, i have no idea who Kevin is. We already have trait Large as mutation, description of Large |
Summary
Bugfixes "Added check for non crammed, removed flag"
Purpose of change
Issue existed for over 2 days decided to fix myself to make experimental playable for tall charcters
(#74068)
#74068
Describe the solution
added condition so character not always be crammed
changed volume to slighlty more reasonable
removed label Large from Tall (let be honest it was needed to be done anyway tall people are not the size of the cow / bear)
Describe alternatives you've considered
pinging @RenechCDDA until he fixes this issue
/
completly removing this detail
Testing
done 2 test with regular and very tall character before and after changes
before regular charcter was cramed and tall character could not enter after both could enter and noone was cramed
Additional context
i m pretty sure that is all