godco predatory trader shouldn't be a random spawn for 0.H #74122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Testing 0.H I spawned in a shelter and a random locker had a huge pile of stuff in it:
This addresses the more root cause of this, which is that the godco "predatory trader" spawned with me in the evac shelter.
This shouldn't happen as this NPC is supposed to spawn with a shop as part of godco mapgen, which gives them somewhere to put their inventory.
The regular trader NPC can still spawn and that's fine as they don't have the boosted trading inventory of a trader with a shop.
Describe the solution
Give the NPC class the "common": false property which keeps them spawning outside their scenario.
Describe alternatives you've considered
None really, this trader just doesn't fit in the evac shelter, or worse wandering around on the map.