Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godco predatory trader shouldn't be a random spawn #74121

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

kevingranade
Copy link
Member

Summary

None

Purpose of change

Testing 0.H I spawned in a shelter and a random locker had a huge pile of stuff in it:
Screenshot from 2024-05-26 11-58-10
Screenshot from 2024-05-26 11-57-45
This addresses the more root cause of this, which is that the godco "predatory trader" spawned with me in the evac shelter.
This shouldn't happen as this NPC is supposed to spawn with a shop as part of godco mapgen, which gives them somewhere to put their inventory.
The regular trader NPC can still spawn and that's fine as they don't have the boosted trading inventory of a trader with a shop.

Describe the solution

Give the NPC class the "common": false property which keeps them spawning outside their scenario.

Describe alternatives you've considered

None really, this trader just doesn't fit in the evac shelter, or worse wandering around on the map.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 26, 2024
@dseguin dseguin merged commit 722b6fb into master May 27, 2024
26 checks passed
@kevingranade kevingranade deleted the uncommon-trader branch May 30, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants