Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed construction marker #74104

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Fix the construction markers that were harmed when 3D basecamp/character construction was introduced.
(Only furniture was indicated).

Describe the solution

Check the proper location for terrain (not Z level -10) and get rid of now unnecessary constant. The code relies on tinymap writing to its only Z level (-10) even though the code specifies the current Z level (typically 0). That behavior is tested for by the unit tests, so it should be very official.

Describe alternatives you've considered

Testing

Ordered a companion to build on an expansion. See construction markers.
Screenshot (403)

Additional context

I don't think there is a bug report.

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 26, 2024
@Maleclypse Maleclypse merged commit 0e9a8b6 into CleverRaven:master May 26, 2024
26 of 28 checks passed
@Maleclypse
Copy link
Member

Thank you for the work you’re doing!

@PatrikLundell PatrikLundell deleted the fix_marker branch May 27, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants