Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special casing test for Alpha and increase vitamin max/thresbreach #74101

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented May 26, 2024

Summary

Balance "Adjust Alpha to make breach harder while supporting future mutations"

Purpose of change

Give alpha differentiation other than "smallest mutation tree".

Describe the solution

Removes the special casing test that limits adding new mutations, adds additional vitamin requirement for threshbreach and adds new max dose of alpha vitamin to support the threshbreach.

Describe alternatives you've considered

Forgetting alpha exists.

Testing

Tested and works fine.

Additional context

@Maleclypse Maleclypse marked this pull request as ready for review May 26, 2024 05:38
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 26, 2024
data/json/vitamin.json Outdated Show resolved Hide resolved
data/json/vitamin.json Outdated Show resolved Hide resolved
@dseguin dseguin merged commit 0bfb3a8 into CleverRaven:master May 27, 2024
21 of 27 checks passed
@Maleclypse Maleclypse deleted the Remove-special-test-for-Alpha-threshbreach- branch May 27, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants