Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine 7.62x51 and .308 casings into one #74090

Closed
wants to merge 4 commits into from
Closed

Combine 7.62x51 and .308 casings into one #74090

wants to merge 4 commits into from

Conversation

Holli-Git
Copy link
Contributor

@Holli-Git Holli-Git commented May 25, 2024 •
edited
Loading

Summary

Bugfixes ".308 and 7.62x51 cases are the same"

Purpose of change

Having .308 and 7.62x51 have separate cases was clunky. You have two recipes for reloaded ammo, you have effectively the same ammo giving different cases, and it adds a bunch of nothing for no real purpose.

Describe the solution

Combines the cases into 1, obsoleting the old 308 cases

Describe alternatives you've considered

Keeping it as is

Testing

Tested locally, works fine, no weirdness in the ammo craft section or uncrafting.

Additional context

Closed, turns out 308 brass and 7.62x51 brass are different enough

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns Items: Armor / Clothing Armor and clothing Mods: Xedra Evolved Anything to do with Xedra Evolved <Bugfix> This is a fix for a bug (or closes open issue) labels May 25, 2024
@github-actions github-actions bot requested a review from Maleclypse May 25, 2024 17:48
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 25, 2024
@Holli-Git Holli-Git closed this May 25, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 26, 2024
@Holli-Git Holli-Git deleted the combine_casing branch August 24, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Generic Guns Anything to do with Generic Guns Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Holli-Git