Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jesse fix #74082

Merged
merged 2 commits into from
May 26, 2024
Merged

Jesse fix #74082

merged 2 commits into from
May 26, 2024

Conversation

TealcOneill
Copy link
Contributor

Summary

None

Purpose of change

Closes #74012

Describe the solution

#73264 accidentally gave Jesse SKIN_ROSE which isn't a valid Skin tone. Changed it to SKIN_PINK

Describe alternatives you've considered

Add a new skin tone, didn't feel like that was necessary

Testing

Loaded up fresh install, got error. Closed and changed JSON. Reloaded and didn't get error + Jesse was a different color sprite.

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 25, 2024
@Maleclypse Maleclypse merged commit b03cb4b into CleverRaven:master May 26, 2024
26 checks passed
@TealcOneill TealcOneill deleted the jesse_fix branch June 8, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load error on skin tone assignment to NPC
2 participants