-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigures 'plastic_molding' recipes to be more accurate #74080
Reconfigures 'plastic_molding' recipes to be more accurate #74080
Conversation
…balances plastic amount
I thought I did a really careful job on this and it didn't really need linting but obviously that's not the case. I'll go through and lint all the files tonight after I get back from work. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
the retractable telescope no longer matches the criteria for this test.
Tests to see if the test is failing because of lack of components. If this fails I will increase the tool_with_ammo( "popcan_stove" 30 ) to tool_with_ammo( "popcan_stove" 60 ) because 30 charges shouldn't be enough to craft this recipe.
This is a shot in the dark and I don't think it will work. Either way I'm going to talk to people in the discord to understand the issue
I'm going to talk to someone on the discord tomorrow to get a hand with this. I'm not absolutely sure it's caused by my changes to the carver since it did finish making it. The first Test test commit is good, the recipe definitely needs that but the second one I think needs to be reverted. |
I've made changes to kick the tests. If they still come back with charges going wrong it's probably something in this PR. |
Electric carver uses plastic molding the test confirms that electric carver requires the number of charges set in the test. You'll need to adjust the number the test is looking for. |
I misunderstood how the multiple tools with enough charges section worked when I changed it in the 'Testing Test 2' commit. |
I misunderstood this before and as such doubled the amount of charges the recipe needed which opened up a new error. Clearing this so I can find the original error.
I think that fixed everything! All failing tests look unrelated |
Summary
Bugfixes "Removes unnecessary use of 'surface_heat' from recipes with 'plastic_molding'"
Purpose of change
Closes #69598
Describe the solution
In all of these recipes the only real possible use for 'surface_heat' was for molding the plastic but 'plastic_molding' already has 'surface_heat' built into it. As such I removed the unnecessary extra use of it.
I also balanced the charges of 'plastic_molding' to get it closer to the 1 use per 70g of plastic as possible.
I fixed small recipes with the assumption of some waste of plastic and so didn't account for the weight of the polycarbonate sheet from the 'plastic_molding' requirement.
For bigger items like the 30gallon drum and plastic boat hulls I did account for the weight of the sheets since it seemed like they would make up a larger amount of the item being easier to turn into a large flat/curved surface.
Describe alternatives you've considered
Using C++ to add the charges of the two requirements together as Guardian suggested
Testing
Just json changes. Loaded it up and looked to make sure it was correct.
Additional context