Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Incorrect Bag Used in Map Xtra #74063

Merged
merged 1 commit into from
May 25, 2024

Conversation

TheMurderUnicorn
Copy link
Contributor

@TheMurderUnicorn TheMurderUnicorn commented May 25, 2024

Summary

Bugfixes "Replace Incorrect Bag Used in Map Xtra"

Purpose of change

#74045 pointed out that the "broken sandbags" used in that location were giving canvas bags. This was an old way of spawning them as destroyed bags with variable amounts of sands. This was incorrect because sandbags no longer use canvas bags, they use bag_durasack

Describe the solution

Change canvas sack to durasack

Describe alternatives you've considered

I debated replacing it completely with the sandbag itemgroup, which already drops an assortment of bags and sand, but it was already set up and really all I had to do was change one id so yeah, I opted for the laziness.

Testing

Game didn't explode, change good.

Additional context

Closes #74045

o_o sacks.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 25, 2024
@Maleclypse Maleclypse merged commit 6a57dbd into CleverRaven:master May 25, 2024
27 checks passed
@TheMurderUnicorn TheMurderUnicorn deleted the sandbagfix branch May 26, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special location mx_roadblock. Map generation error
2 participants