-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jewelry addition #74033
Merged
Maleclypse
merged 44 commits into
CleverRaven:master
from
aapocalypseAArisen:Jewelry-addition
May 26, 2024
Merged
Jewelry addition #74033
Maleclypse
merged 44 commits into
CleverRaven:master
from
aapocalypseAArisen:Jewelry-addition
May 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in all jewelry into jewelry.json
Added deconstruct recipe to new jewelry.
Added metal anklets to female child spawn group. Assuming it also filters into the adult female spawn group.
Added metal anklets to valuable pawn. Non metal to normal pawn.
Added non metal anklets to domestic spaces.
Put metal anklets into memorabilia bug out bag.
Added metal anklets in the category of other general metal jewelry.
Added metal anklets to contraband.
Removed line errors.
Removed line error.
Removed line error.
Removed line error
Added lip rings to women specific loot pool.
Accounted for gold vs silver.
Added lip rings to valuable pawn spawns.
Added lip rings to messy drawers.
Added nose rings to messy drawers.
Added nose rings to valuable pawn spawns.
Added nose rings to women specific accessory spawns.
Added toe rings to female child accessories which will filter into adult female accessories.
Added toe rings to valuable pawn loot pool.
Added toe rings to messy drawer spawns.
Fix line division error causing hard crash.
Fixed line error causing hard crash.
Fixed line error causing crash.
Fixed missing " in several lines.
Removed presumed unnecessary plural naming.
Fixed missing , .
Removed extra commas.
Remove mouth coverage on lip rings, presumably causing errors.
Adjusted anklet values.
Adds cotton to anklet materials.
Remove disassembly requirements from bat and flower charm anklets.
Removed the extra word charm from plastic anklets.
Changed gold nose ring stud symbol from o to . .
Removed head coverage specification from lip ring.
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Spawn
Creatures, items, vehicles, locations appearing on map
Items: Armor / Clothing
Armor and clothing
labels
May 24, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
May 24, 2024
All checks passed. Looks like it is ready to fire. Unless someone else has any additional observations. |
Here is confirmation of my request with the discord name Eight Spades. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Items: Armor / Clothing
Armor and clothing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "New jewelry added"
Purpose of change
The range of jewelry currently in the game is vast and varied. However, there are some categories of accessories not touched upon. I wanted to add to those unexplored categories. Perhaps being the first of further additions in this new addition of cosmetics.
Describe the solution
Added new cosmetics. Gold and silver lip ring stud and loops. Gold and silver nose ring stud and loops. Gold, silver and plastic anklets. Gold and silver toe rings.
Describe alternatives you've considered
Simply leaving these categories of cosmetics untouched.
Testing
Booted a new world with no error message. Checked and confirmed item disassembly was working as intended. Wore the jewelry with normal clothes to confirm that there were no conflicts with other clothing. Checked the item descriptions to make sure the values were as desired. Teleported to a nearby city and killed zombies to confirm that the new additions were actively in the loot pools.
Additional context
My reasoning for each of the loot pool groups:
Anklets-
Jewelry.json - self explanatory.
Clothing.json - accesories_personal_womens_child Metal anklets in female child spawn group with the assumption that it will filter into the adult female spawn group.
Location_commercial.json - Pawn_valuable for metal anklets, Pawn for non metal anklets. Seems self explanatory. People will sell any bit of gold or silver for cash.
domestic.json - SUS_junk_drawer_artsy and SUS_junk_drawer_messy for non metal anklets. They're likely pieces that a creative person would make. And personally, I can confirm I have bracelets and other minor cosmetics in my messy junk drawer IRL.
stashes.json - bugout_memento for the metal anklets. Seems appropriate, valuable gold and silver items scooped into a bag of closely held possessions.
jewelry_gems.json - jewelry_accessories for the metal anklets. This loot pool seemed like the general loot pool for common jewelry.
NC_CITY_COP.json - NC_CITY_COP_misc For the metal anklets. I believe I recognized this loot pool as the contraband room loot pool. So this seems appropriate. Petty thieves pilfering small bits of gold and silver then getting caught.
Lip rings:
jewlery.json - Self explanatory.
clothing.json. - accesories_personal_womens for it to spawn on adult women.
locations_commercial.json - pawn_valuable Same reason as anklets.
domestic.json - SUS_junk_drawer_messy For having small cosmetics scattered around old drawers. Personally, I have old metal bracelets I've not worn in years in my drawers.
Nose rings:
Jewlery.json - Self explanatory.
clothing.json - accesories_personal_womens Same reason as above.
locations_commercial.json - pawn_valuable Same reason as above.
domestic.json - SUS_junk_drawer_messy Same reason as above.
Toe rings:
Jewlery.json - Self explanatory.
clothing.json - accesories_personal_womens_child Because it seemed like appropriate cosmetics for female children wear. Also with the understanding that it will filter into adult women loot pool.
locations_commercial.json - pawn_valuable Same reason as above.
domestic.json - SUS_junk_drawer_messy Same reason as above.