Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Make Paraclesian fae's magic harder in some circumstances #74029

Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented May 24, 2024

Summary

Mods "[Xedra Evolved] Make Paraclesian fae's magic harder in some circumstances"

Purpose of change

Counterpoint to #74027

Describe the solution

Add EoCs that increase the effective Difficulty of spells by +3 based on local conditions.

  • Arvore: Being in an artificial structure, unless it's made of wood or dirt and away from civilization
  • Homullus: Being in the wilderness ("near a road" is not the wilderness)
  • Ierde: Being at Z level 1 or above
  • Salamander: Being in freezing temperatures and not near a fire.
  • Sylph: Being underground
  • Undine: Being away from the water for more than six hours (either standing in water or being near a large body of water resets the timer).

I also updated the profession description for each type of fae to explain where they are strong and where they are weak.

Describe alternatives you've considered

Testing

Each EoC works properly.

Drafting until the preceding PR is merged.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft May 24, 2024 00:27
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels May 24, 2024
@github-actions github-actions bot requested a review from Maleclypse May 24, 2024 00:27
@github-actions github-actions bot added Mods: Xedra Evolved Anything to do with Xedra Evolved astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 24, 2024
@Maleclypse
Copy link
Member

It might be good to mention this and the predecessor PR in either the professions and/or the documents that the paraclesians start with.

@Standing-Storm
Copy link
Contributor Author

I feel like putting it in the profession description is probably the best bet. The writers of those notes seem to trust their offspring to figure things out on their own, so an OOC warning is probably for the best.

@github-actions github-actions bot added the Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies label May 24, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • With the dimensional spillage that preceded the Cataclysm you are the spirit of a place that slowly gained sentience, a genius loci. As the world reshapes itself you have decided to wander from your birthplace and determine where you will end up.\n\nAs a spirit of the flames, your powers are strengthened when among heat and fire and weakned by the cold.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Standing-Storm Standing-Storm marked this pull request as ready for review May 24, 2024 19:22
@Maleclypse Maleclypse merged commit 5abcd46 into CleverRaven:master May 26, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm deleted the elemental-magic-penalties branch May 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants