Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regen serum #74021

Merged
merged 13 commits into from
May 31, 2024
Merged

Add regen serum #74021

merged 13 commits into from
May 31, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented May 23, 2024

Summary

Content "Regen serum"

Purpose of change

Adress #53141

Describe the solution

Add Serum 48x-"Locutus" from 53141
Implementation is not 100% matches Erk expectations, but i think most of stuff is good enough
one by one:

Erk suggestion This implementation
Rapid healing, including healing of nerve damage and regeneration of limbs. Rapid healing - check, mending limbs - check. Everything else is omitted because of lack of mechanics
Healing causes extremely rapid calorie expenditure. Check
Inadequate calorie intake can lead to rapid muscle wasting (loss of strength and cardio) Consuming less calories than you spend cut your cardio and str, up to -60%. Probably need something better, that takes into account more than one day, but it's hard to do anything reasonable since the thing itself last only a day or two
Increased need for sleep while under effects Check
Bouts of extreme pain Check
Vomiting, making calorie intake more difficult Check
Severe teratogenicity, leading to rejection of project. This drug will probably give you cancer later in life, especially with repeated use Hard to implement, i guess the best would be making some snippet somewhere, but i should ask someone else to do it, i'm very much not a writer; i also don't think it should be in the same box as the serum itself, rather some outer report
May randomly cause gain or loss of mutations or rejection of cybernetics (neither effect known to xedra) mutation part - check; cybernetic part - omitted, for i don't know how to make it
Strength wasting effect lasts a few days before fading back to normal Check
- Character also suffer from sleepiness and stamina regen penalty for some longer time; i honestly don't rememeber when and why i made it, i can remove it if it's desired

Testing

GIF 30-05-2024 20-00-23

Additional context

@I-am-Erk just want you to sanify the numbers or check if i can add some json infra for the future, if you have some free time

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map EOC: Effects On Condition Anything concerning Effects On Condition astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 23, 2024
@worm-girl
Copy link
Contributor

Teratogenicity (is that even a word) is represented elsewhere by a large hit to the lifestyle score which seems more than appropriate here. You're trading rapid emergencg healing for long term wellbeing.

@I-am-Erk
Copy link
Member

In this case I think teratogenicity should be just fluff, I don't seriously think we should give characters cancer.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 24, 2024
@GuardianDll
Copy link
Member Author

🤔
image-51

@osuphobia
Copy link
Contributor

🤔 image-51

Caused by get_calories_daily('type':'ingested', 'day':'1') and get_calories_daily('type':'spent', 'day':'1') be 0?

@GuardianDll
Copy link
Member Author

Very possible, actually. I don't know why it result in stack overflow, but at least it's not a segfault

Copy link
Contributor

@osuphobia osuphobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these can help solving the error.

data/json/items/comestibles/serums.json Outdated Show resolved Hide resolved
data/json/items/comestibles/serums.json Show resolved Hide resolved
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 29, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 30, 2024
@GuardianDll GuardianDll marked this pull request as ready for review May 30, 2024 17:52
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Inject subject with 10 ml of 48x-"Locutus" compound\nObserve for 6 hours\nNote: subject has left arm amputated and bald.\nResults: Subject suffered from heavy vomiting, physical weakness, sleepiness, and sudden spiked of pain. Subject arm was regenerated, with no functional loss, which was confirmed in future tests. Subject hair grow showed an exceptional rate, with approximately 1 cm in 6 hours.\nLong term results: approximately 24 hours after the injection the regeneration speed returned to normal rate. In two weeks, most of negative effects were rounded off. Full body inspection revealed mostly positive changes, healing of previously damaged internal organs, notably liver, thyroid gland and spine. Subject cataract were not cured, for some reason.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Maleclypse Maleclypse merged commit cef5d70 into CleverRaven:master May 31, 2024
26 checks passed
@Maleclypse
Copy link
Member

This is awesome! Great work!

@GuardianDll GuardianDll deleted the serum branch May 31, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants