Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added roof to A/C carrier #74019

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented May 23, 2024

Summary

None

Purpose of change

Provide the A/C carrier with an explicit roof in preparation for the removal of roof magic.

Describe the solution

Add another level to the carrier containing the roof (and some decorations on it).
Also fixed a broken railing.

Describe alternatives you've considered

Make the roof out of the same stuff as the deck is made out of.

Testing

  • Hack add_roofs to disable the magic.
  • Debug spawn a carrier special.
  • Teleport to it.
  • Teleport around to inspect it.
  • Verify there is no roof on the tower.
  • Add the roof and repeat the above (less teleporting around for inspection).
  • Declare the roof to be good.
  • Restore the hacked code.

Screenshot (379)

Additional context

It's a bit silly to have zombies spawn in the air in droves. I don't think The Weather Girls would approve of this twist on their hit.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 23, 2024
@dseguin dseguin merged commit 23b70a4 into CleverRaven:master May 23, 2024
27 checks passed
@PatrikLundell PatrikLundell deleted the ac_carrier branch May 23, 2024 19:19
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants