Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit roofs on workshop version 2 expansion #74018

Merged
merged 2 commits into from
May 23, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Provide explicit roofs on workshop expansion 2 rather than rely on roof adding magic.

Describe the solution

Update the palettes, use Z coordinates, define roofs and chimneys, and apply those.

Describe alternatives you've considered

Testing

  • Load a suitable save and survey a workshop 2 expansion.
  • Build the 6 sections out of different materials.
  • Build the furniture that should have chimneys.
  • Check that it looks as expected.
  • Reload the save and build two sections out of the last two materials.
  • Check the results.
    Screenshot (375)
    Screenshot (376)
    Screenshot (377)
    Screenshot (378)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels May 23, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 23, 2024
…2/modular_workshop_common.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 23, 2024
@dseguin dseguin merged commit bac4b10 into CleverRaven:master May 23, 2024
18 of 24 checks passed
@PatrikLundell PatrikLundell deleted the workshop2 branch May 23, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants